[php-src] PR #21709: ext/zip: use php_globfree wrapper in addGlob early returns
| From: | iliaal | Date: | Fri, 10 Apr 2026 11:47:12 +0000 |
| Subject: | [php-src] PR #21709: ext/zip: use php_globfree wrapper in addGlob early returns | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35657@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21709
Author: iliaal
Master fails to build on ALPINE_X64_ASAN_DEBUG_ZTS, LINUX_X64_ASAN_DEBUG_ZTS, LINUX_X64_RELEASE_NTS,
MACOS_ARM64_DEBUG_NTS, and FREEBSD_NTS with:
```
ext/zip/php_zip.c:679:17: error: implicit declaration of function 'globfree'; did you mean
'php_globfree'? [-Werror=implicit-function-declaration]
```
GH-21702 added two
globfree(&globbuf) calls at ext/zip/php_zip.c:679
and :686 for the no-match and open_basedir reject paths. I switched both to
php_globfree(), matching the existing call at line 715 and the
main/php_glob.h convention.
Two-line change. Fixes the build on affected platforms without touching behavior.