[php-src] PR #21976: Preserve full XMM registers in Windows VM wrapper

From: Date: Thu, 07 May 2026 16:40:04 +0000
Subject: [php-src] PR #21976: Preserve full XMM registers in Windows VM wrapper
Groups: php.git-pulls 
Request: Send a blank email to git-pulls+get-36048@lists.php.net to get a copy of this message
Pull Request: https://github.com/php/php-src/pull/21976 Author: shivammathur We do PGO-optimized builds for Windows releases. In our builds CI, some recorded-error tests are failing on the master branch: https://github.com/shivammathur/php-windows-builder/actions/runs/25329578176/job/74262237899#step:6:197 https://github.com/shivammathur/php-windows-builder/actions/runs/25329578176/job/74262237943#step:6:477 After checking the trace from the build, orig_errors_buf in zend.c was stored in XMM6 in the PGO build, but the Windows VM wrapper was only preserving half of the XMM registers when execution re-entered the VM: https://github.com/php/php-src/blob/b5b2c5dfb847d0f85e51ebd2448db4627cf14266/Zend/zend.c#L1581 So the lower half was restored correctly, but the upper half, which contained the pointer to the recorded errors array, was lost. That left EG(errors) in an invalid state with a non-zero size but a null errors pointer. This fixes the wrapper to save and restore the full XMM6-XMM15 registers.

« previous php.git-pulls (#36048) next »