[php-src] PR #22147: [ext/standard] Move min/max array fallback into array.c
| From: | mehmetcansahin | Date: | Mon, 25 May 2026 10:43:02 +0000 |
| Subject: | [php-src] PR #22147: [ext/standard] Move min/max array fallback into array.c | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-36234@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22147
Author: mehmetcansahin
Split out from #22127 as the behavior-preserving baseline refactor requested during review.
This moves the generic min()/max() array fallback out of the Zend HashTable API and into
ext/standard/array.c, where it is the only remaining user. The local helper uses the regular
ZEND_HASH_FOREACH_VAL() API and calls zend_compare() directly, avoiding the previous
function-pointer wrapper.
UPGRADING.INTERNALS is updated to document that zend_hash_minmax() is no longer exposed.
Tested with:
- make -j"$(sysctl -n hw.ncpu)"
- sapi/cli/php run-tests.php -q ext/standard/tests/array/min*.phpt
ext/standard/tests/array/max*.phpt