[php-src] PR #22265: Another tailcall vm_interrupt bug
| From: | morrisonlevi | Date: | Tue, 09 Jun 2026 20:38:10 +0000 |
| Subject: | [php-src] PR #22265: Another tailcall vm_interrupt bug | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-36355@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22265
Author: morrisonlevi
We fixed a bug in the tailcall VM in 8.5.7. Unfortunately I was able to find another crash. This has
a reproducer.
Note that the ["return opline"
variant](https://github.com/php/php-src/pull/21922/changes/914efebf89b4ada533e9a528943eee96db7733fb)
that Arnaud benchmarked passes this test.
We could alternatively do:
```diff
diff --git a/Zend/zend_vm_gen.php b/Zend/zend_vm_gen.php
index 1ffa80f718d..eda8b5b11ea 100755
--- a/Zend/zend_vm_gen.php
+++ b/Zend/zend_vm_gen.php
@@ -2328,6 +2328,7 @@ function gen_executor($f, $skl, $spec, $kind, $executor_name,
$initializer_name)
$m[1]."opline = (const zend_op*)((uintptr_t)opline &
~ZEND_VM_ENTER_BIT);\n".
$m[1]."if (EXPECTED(opline != NULL)) {\n" .
$m[1]."\texecute_data = EG(current_execute_data);\n".
+ $m[1]."\tSAVE_OPLINE();\n".
$m[1]."\tZEND_VM_LOOP_INTERRUPT_CHECK();\n".
$m[1]."} else {\n" .
"# ifdef ZEND_VM_IP_GLOBAL_REG\n" .
```