[php-src] PR #22330: ext/phar: Fix ZIP extra field length underflow in Phar

From: Date: Tue, 16 Jun 2026 08:24:18 +0000
Subject: [php-src] PR #22330: ext/phar: Fix ZIP extra field length underflow in Phar
Groups: php.git-pulls 
Request: Send a blank email to git-pulls+get-36455@lists.php.net to get a copy of this message
Pull Request: https://github.com/php/php-src/pull/22330 Author: LamentXU123 Now the parser used a uint16_t remaining-length counter and subtracted the extra field payload size plus header size without first validating that the parsing data past the extra field boundary. So, a malformed zip .phar file with a huge extra field can trigger an underflow. See ```php <?php function u16($v) { return pack('v', $v); } function u32($v) { return pack('V', $v); } $f = __DIR__ . '/poc.zip'; $name = 'a'; $data = 'x'; $crc = crc32($data); $local = u32(0x04034b50) . u16(20) . u16(0) . u16(0) . u16(0) . u16(0) . u32($crc) . u32(strlen($data)) . u32(strlen($data)) . u16(strlen($name)) . u16(0) . $name . $data; /* extra_len = 4, but sub-header says payload size = 1. */ $extra = 'XX' . u16(1); /* Old parser seeks 1 byte past the extra field, then parses this comment data. */ $prefix = 'A' . 'UT' . u16(5) . "\x01" . u32(114514191) . 'ZZ' . u16(65522); $comment = $prefix . str_repeat('B', 65535 - strlen($prefix)); $central = u32(0x02014b50) . u16(20) . u16(20) . u16(0) . u16(0) . u16(0) . u16(0) . u32($crc) . u32(strlen($data)) . u32(strlen($data)) . u16(strlen($name)) . u16(strlen($extra)) . u16(strlen($comment)) . u16(0) . u16(0) . u32(0) . u32(0) . $name . $extra . $comment; $eocd = u32(0x06054b50) . u16(0) . u16(0) . u16(1) . u16(1) . u32(strlen($central)) . u32(strlen($local)) . u16(0); file_put_contents($f, $local . $central . $eocd); try { $p = new PharData($f); echo "BUG: corrupt zip loaded\n"; echo "mtime: ", $p[$name]->getMTime(), "\n"; } catch (Exception $e) { echo "fixed: ", $e->getMessage(), "\n"; } ``` the mtime will become a controlled 114514191. The malformed ZIP has central extra_len = 4, but the first extra sub-header declares size = 1. The old parser subtracts 5 from a uint16_t length counter, underflows, then continues parsing past the extra field boundary. So it parses file comment bytes as a UT extra field, which makes the mtime 114514191. ``` BUG: corrupt zip loaded mtime: 114514191 ``` The fix is to validate each extra field sub-header before consuming it.

« previous php.git-pulls (#36455) next »