[php-src] PR #22363: Fix GH-22051: report errors from SQLite3Result reset and finalize
| From: | iliaal | Date: | Thu, 18 Jun 2026 23:07:58 +0000 |
| Subject: | [php-src] PR #22363: Fix GH-22051: report errors from SQLite3Result reset and finalize | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-36503@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22363
Author: iliaal
SQLite3Stmt::reset() reports a failed sqlite3_reset() through php_sqlite3_error(), but
SQLite3Result::reset() returned false silently and SQLite3Result::finalize() ignored the result.
Both now report the same way; finalize() keeps its : true return type and reports without changing
it. The other sqlite3_reset/sqlite3_finalize calls are left unchecked deliberately: resets after a
successful step cannot fail, the reset-before-execute for bug #77051 returns the prior run's
stale code, the error-path finalize calls would re-report an error already surfaced in the same
function, and the destructor calls have no userland frame to report from.
Fixes php/php-src#22051