[php-src] PR #22552: ext/iconv/tests/bug48147.phpt: blacklist unknown iconv
| From: | orlitzky | Date: | Thu, 02 Jul 2026 14:09:13 +0000 |
| Subject: | [php-src] PR #22552: ext/iconv/tests/bug48147.phpt: blacklist unknown iconv | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-36781@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22552
Author: orlitzky
Fix the last failure in https://github.com/php/php-src/issues/22413
PHP has
ICONV_BROKEN_IGNORE for implementations (glibc) that return an
EILSEQ when they //IGNORE an invalid sequence, but some implementations
(musl) don't support //IGNORE at all. We blacklist those implementations in the
test since //IGNORE is now part of the standard (not supporting it is "bad"),
but there is nothing PHP can do about it.
Whatever libc does ultimately has to be OK. I think this needs better documentation
(https://github.com/php/doc-en/issues/5646) rather than more code.
We should probably be blacklisting BSD and IBM iconv as well, but I don't have them available
to test.