[php-src] PR #22652: Fix GH-22649: avoid ZipArchive comment reset crash
| From: | LamentXU123 | Date: | Thu, 09 Jul 2026 10:20:17 +0000 |
| Subject: | [php-src] PR #22652: Fix GH-22649: avoid ZipArchive comment reset crash | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-36930@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22652
Author: LamentXU123
Rewrite the
PHP_ZIP_SET_FILE_COMMENT macro to solve this uaf that occurs after
overwriting an existing entry and setting its inherited unchanged comment again.
I also add some defensive checks in the function by the way (ZEND_ASSERT(comment_len <=
0xffff);) just in case someone will re-use this helper in the future.