[php-src] PR #22708: Fix flaky poll socket close tests on Solaris event ports
| From: | bukka | Date: | Sun, 12 Jul 2026 18:51:08 +0000 |
| Subject: | [php-src] PR #22708: Fix flaky poll socket close tests on Solaris event ports | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-36996@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22708
Author: bukka
After the peer closes, Solaris event ports fire a one-shot snapshot as soon as the socket is
writable and may not yet have folded the peer close into a POLLHUP, so the wait() sometimes reports
Write without HangUp.
Make HangUp optional for the EventPorts backend in the affected tests while keeping Write (and all
other backends) strict. The pt_events_equal() helper now treats a nested array in the expected
events as an optional slot, and pt_event_array_to_string() renders it in brackets. A manual
self-test for this matching logic is included in poll.inc (runs only when the file is executed
directly, never in CI).