[php-src] PR #22791: odbc: Quote spaces in UID/PWD appended to connection string
| From: | NattyNarwhal | Date: | Fri, 17 Jul 2026 16:45:57 +0000 |
| Subject: | [php-src] PR #22791: odbc: Quote spaces in UID/PWD appended to connection string | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37129@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22791
Author: NattyNarwhal
Drivers have no standard parsing, and may react weirdly to spaces in a connection string. When we
append the UID/PWD parameters for the user and pass parameters of
odbc_(p)connect or
the PDO constructor, add spaces to the list of characters that require quoting.
This fixes issues related to significant whitespace possibly not being parsed in a username or
password, or having whitespace mangle parsing of a connection string. Note that there is no security
impact because in order to do something interesting, you must be able to control the ';='
characters, and we already quote in those cases.