[php-src] PR #22838: ext/standard: stream_filter_register() orphaned user_filter_map on sh…
| From: | devnexen | Date: | Mon, 20 Jul 2026 20:49:23 +0000 |
| Subject: | [php-src] PR #22838: ext/standard: stream_filter_register() orphaned user_filter_map on sh… | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37210@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22838
Author: devnexen
…utdown re-registration.
Fix GH-22818
During request shutdown the user_filter_map is torn down by the user_filters RSHUTDOWN before the
streams referencing it are flushed. A user filter whose filter() callback re-registers the filter
recreated the now-NULL map, then, since the volatile factory was still present in
FG(stream_filters), deleted the freshly added entry and left an empty orphaned map behind. The
following stream_filter_append() located the factory but no matching fdat, tripping
ZEND_ASSERT(fdat), and the recreated map leaked.
Register the volatile factory first and only create and populate user_filter_map on success, so a
re-registration during the shutdown window fails without recreating the map. The existing NULL-map
guard in user_filter_factory_create() then handles the append gracefully.