[php-src] PR #22865: Remove `param` argument from `php_verror`
| From: | NattyNarwhal | Date: | Wed, 22 Jul 2026 21:20:05 +0000 |
| Subject: | [php-src] PR #22865: Remove `param` argument from `php_verror` | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37240@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22865
Author: NattyNarwhal
Update tests and
UPGRADING.INTERNALS.
Note there is some impact to extensions if they call this; however, it's usually in a
centralized wrapper function which is easy to update. In my quick skim of external extensions, apcu
is the only one that'll need an update.
Also note that php_verror is a bit weirdly named. It should probably be called
something like php_docref_verror, since php_error_docref the vararg
wrapper around it (now that 1/2 are gone); let me know if this is something worth pursuing. There is
php_error, which is just an alias for zend_error, which doesn't take
a docref, nor does it have the function and args prefix that php_verror has. It should
be used for engine stuff, but I think there are a few places where it's called from places
where php_error_docref should be used instead in extensions. I can take a look at that
too.