[php-src] PR #22927: Convert usage of `php_error`/`zend_error` to `php_error_docref`
| From: | NattyNarwhal | Date: | Wed, 29 Jul 2026 21:42:46 +0000 |
| Subject: | [php-src] PR #22927: Convert usage of `php_error`/`zend_error` to `php_error_docref` | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37344@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/22927
Author: NattyNarwhal
Not yet complete. Some notes so far:
* The goal is to eventually eliminate
php_error as an alias for
zend_error, make error reporting more consistent, and eventually figure out some
symmetry between php_verror and php_error_docref naming wise.
zend_error should remain, but there may be quite a bit of overlap anyways.
* I'm starting with ext since this usually is for functions where the
php_error_docref output makes sense when prefixing with a function name and optionally
arguments (or indicating phase of startup/shutdown). There are some notable exceptions (some stuff
related to arrays and comparisons) that do not work in that context.
* There may be some stuff in Zend and sapi too.
* Deprecation messages tend to repeat the function name, so I haven't changed those. Perhaps
there should be some kind of function for consistent deprecation messages?
* The changes to ext/soap are a bit wider, getting rid of some pointless macros and
replacing the SOAP-ERROR prefix with the function prefix from docref output. This could
be broken out into a separate PR.
* A lot are in hard to reach areas without tests to validate. Some of these may make more sense as
exceptions, for instance.