[php-src] PR #23108: ext/zip: addGlob() and addPattern() ignore their default options.
| From: | devnexen | Date: | Fri, 07 Aug 2026 19:16:15 +0000 |
| Subject: | [php-src] PR #23108: ext/zip: addGlob() and addPattern() ignore their default options. | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37628@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/23108
Author: devnexen
php_zip_parse_options() held the defaults but only ran for a non-empty options array, so opts stayed
zeroed otherwise: comp_method 0 is CM_STORE and flags 0 drops FL_OVERWRITE. Entries were therefore
stored uncompressed, and an already present entry name failed the call instead of being replaced.
The defaults now live in PHP_ZIP_DEFAULT_OPTIONS, applied at declaration.