[php-src] PR #23138: ext/gd: Fix two external libgd tests
| From: | lotharsm | Date: | Sat, 08 Aug 2026 08:07:13 +0000 |
| Subject: | [php-src] PR #23138: ext/gd: Fix two external libgd tests | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37646@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/23138
Author: lotharsm
After https://github.com/php/php-src/blob/bf5141c5e66b2f93c089fd91ae0d03947fb310f4/ext/gd/gd.c#L302,
the expected output of the bundled libgd matches the expected output when using an external libgd.
Without this change, the test suite fails when using external gd.
This leaves us with the following test failures, all with external gd:
```
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Bug #65148 (imagerotate may alter image dimensions) [ext/gd/tests/bug65148.phpt]
Bug #73272 (imagescale() is not affected by, but affects imagesetinterpolation())
[ext/gd/tests/bug73272.phpt]
Bug #73291 (imagecropauto() $threshold differs from external libgd) [ext/gd/tests/bug73291.phpt]
=====================================================================
```
ext/gd/tests/bug73291.phpt is related to differences in the algorithm between the
current stable libgd-2.3.3 and the bundled 2.4 pre-release, so we either need to split this into a
new _external test, which will cause issues when distributions eventually start to ship a future 2.4
release, or we need to guard this behind a version check.
Not sure about the other two failing tests though.