[php-src] PR #23297: session: fix some expectations for C session handlers
| From: | Girgias | Date: | Sat, 15 Aug 2026 15:04:30 +0000 |
| Subject: | [php-src] PR #23297: session: fix some expectations for C session handlers | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-37895@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/23297
Author: Girgias
We *explicitly* say that mod_data will be not NULL for create_sid hooks and we violate this
invariant if SessionHandler::open() is overwridden without calling the parent method.
At the same time add comments explaining the situation and fix some other potential footguns.