[php-src] PR #23465: Return false from rewrite_name_to_position() on IM001 error path
| From: | iliaal | Date: | Tue, 25 Aug 2026 23:17:32 +0000 |
| Subject: | [php-src] PR #23465: Return false from rewrite_name_to_position() on IM001 error path | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-38146@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/23465
Author: iliaal
rewrite_name_to_position() is declared bool, so the -1 returned after raising the IM001 error for a
repeated :named parameter was converted to true and the caller's failure check never saw the
failure, leaving bindParam() and bindColumn() reporting success despite the error. Returning false
makes the error propagate; no other -1 return remains in the function.