[php-src] PR #23612: odbc: make odbc_sql_error() formattable, drop odbc_colattribute_failed
| From: | iliaal | Date: | Mon, 07 Sep 2026 22:53:24 +0000 |
| Subject: | [php-src] PR #23612: odbc: make odbc_sql_error() formattable, drop odbc_colattribute_failed | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-38380@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/23612
Author: iliaal
Follow-up to #23601, per your suggestion there.
odbc_sql_error() takes a format now, so
the two SQLColAttribute sites can name the column and the ad-hoc helper is gone. The other 50
callers pass a plain literal and needed no change; the printf attribute covers them.
I left the SQLError in odbc_cursor() alone. It reads SQLSTATE S1015 and synthesizes a cursor name
from that, so it wants its own change rather than a swap. Routing the SQLColAttribute failures
through odbc_sql_error() also populates the connection's last-error state, so odbc_error() and
odbc_errormsg() now report them, hence the NEWS line.