[php-src] PR #24146: Fix leaks and data loss when user filter leaves buckets on input brigade
| From: | bukka | Date: | Mon, 05 Oct 2026 20:00:20 +0000 |
| Subject: | [php-src] PR #24146: Fix leaks and data loss when user filter leaves buckets on input brigade | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39185@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24146
Author: bukka
The callers expect the input brigade to be empty when the filter returns, so buckets left on it
leaked. Buckets put back with PSFS_FEED_ME to be seen again with the next data are now kept by the
user filter and prepended to its input on the next call, which also fixes them aliasing the read
chunk buffer, being re-filtered by preceding filters in a chain and being lost on the write path.
Leftover buckets on any other status, or on the closing call, are released with the existing
warning.
This is alternative to #20058