[php-src] PR #24259: Fix GH-24256: fclose() returns false for wrappers without stream_flush()
| From: | lazerg | Date: | Sun, 11 Oct 2026 10:36:00 +0000 |
| Subject: | [php-src] PR #24259: Fix GH-24256: fclose() returns false for wrappers without stream_flush() | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39339@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24259
Author: lazerg
Since c07cc8502c,
fclose(), file_put_contents() and copy()
return the result of the flush on close. php_userstreamop_flush() returns -1 when the
wrapper has no stream_flush() method, so every write to such a wrapper now makes these
functions return false. A missing stream_flush() now counts as nothing to flush, which
is what the flush op contract in php_streams.h says.
Fixes #24256