[php-src] PR #24659: Fix GH-24637: Check all parent interface constructors
| From: | HarshitBavaliya | Date: | Sat, 24 Oct 2026 18:10:35 +0000 |
| Subject: | [php-src] PR #24659: Fix GH-24637: Check all parent interface constructors | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39835@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24659
Author: HarshitBavaliya
Fixes GH-24637.
> An overriding constructor is currently checked against only the single
> interface constructor held as its prototype. When a parent implements
> multiple interfaces, another interface may impose a stricter signature.
> Check a child constructor against each constructor declared by the parent's
> implemented interfaces.
>
> Remove the XFAIL from the existing reproducer and document this newly
> enforced compatibility error in UPGRADING.
>
> Validation:
> -
make -j$(nproc) with --disable-all
> --enable-cli --disable-cgi --without-pear
> - Both constructor prototype PHPTs pass.
> - Zend inheritance suite: 69 passed, 2 skipped, 0 failed.
>
> This pull request description was prepared with AI assistance.