[php-src] PR #24681: ext/intl: Use C++ idioms in locale_methods.cpp
| From: | devnexen | Date: | Sun, 25 Oct 2026 11:41:36 +0000 |
| Subject: | [php-src] PR #24681: ext/intl: Use C++ idioms in locale_methods.cpp | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39859@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24681
Author: devnexen
First step in moving ext/intl from C-style code towards C++.
Replace the uloc_* buffer/retry loops with helpers that preflight the call and return an exactly
sized zend_string or icu::UnicodeString. Also use LocalUEnumerationPointer,
icu::Locale::getDefault() and C++ casts.
The uloc_* accessors are kept: icu::Locale normalises the ID and would change results for existing
inputs. Further C++ replacements need a newer ICU than the 57.1 minimum: Locale::addLikelySubtags(),
minimizeSubtags() and std::string getKeywordValue() (ICU 63), LocaleMatcher for acceptFromHttp (ICU
65).