[php-src] PR #24750: Fix GH-24745: File cache loses attributes on constants on 32-bit builds
| From: | lazerg | Date: | Mon, 26 Oct 2026 15:43:37 +0000 |
| Subject: | [php-src] PR #24750: Fix GH-24745: File cache loses attributes on constants on 32-bit builds | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39916@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24750
Author: lazerg
On 32-bit builds
RT_CONSTANT() returns opline->op1.zv, which still
points at the literal in script->mem when the attributes are serialized. So
SERIALIZE_ATTRIBUTES() rewrote the live script's pointer and left a raw one in the
cache file. Translate the literal into the buffer first, the same way the
ZEND_INIT_FCALL code below does. The fix is the one suggested in the issue.
Fixes #24745