[php-src] PR #24776: ext/intl: Clarify ICU version requirements in intl test skip messages
| From: | LamentXU123 | Date: | Tue, 27 Oct 2026 07:44:31 +0000 |
| Subject: | [php-src] PR #24776: ext/intl: Clarify ICU version requirements in intl test skip messages | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39956@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24776
Author: LamentXU123
The SKIPIF debugging message is a complete mess.
SKIP for ICU > XX.X is a very vague
wording. It can mean we skip when ICU is bigger than XX.X and also can mean when ICU is smaller or
equal to XX.X
https://github.com/php/php-src/blob/1cc5591b482e3ec603403f222a442e1bfcd77ff1/ext/intl/tests/bug69398.phpt#L7
https://github.com/php/php-src/blob/1cc5591b482e3ec603403f222a442e1bfcd77ff1/ext/intl/tests/bug69398-icu74.1.phpt#L7
https://github.com/php/php-src/blob/1cc5591b482e3ec603403f222a442e1bfcd77ff1/ext/intl/tests/rangeformatter/basic.phpt#L7-L8
https://github.com/php/php-src/blob/1cc5591b482e3ec603403f222a442e1bfcd77ff1/ext/intl/tests/breakiter_getLocale_basic2.phpt#L6
https://github.com/php/php-src/blob/1cc5591b482e3ec603403f222a442e1bfcd77ff1/ext/intl/tests/timezone_IDforWindowsID_basic_icu58_1.phpt#L7
Those are just some examples. Let's instead use skip this test because it requires ICU
...