[php-src] PR #24797: Fix race between the two stream_server_reneg_limit tests
| From: | Truta446 | Date: | Tue, 27 Oct 2026 18:12:50 +0000 |
| Subject: | [php-src] PR #24797: Fix race between the two stream_server_reneg_limit tests | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-39995@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/24797
Author: Truta446
>
stream_server_reneg_limit_trampoline.phpt (added in 67739930ba)
> reuses the temporary certificate file of
> stream_server_reneg_limit.phpt. Since run-tests runs tests in
> parallel, one test can overwrite or delete the other's certificate while it is in use, so
> stream_socket_accept() fails with "Unable to set local cert
> chain file .../stream_server_reneg_limit.pem.tmp". This is the
> intermittent failure of both tests in the nightly runs (e.g. master LINUX_X64_RELEASE_ZTS and
> LINUX_X64_DEBUG_ZTS on 2026-10-27).
>
> This gives the trampoline test its own file.
>
> Running both tests together with -j2 20 times on master:
> before, 6 clean runs, 13 that only passed on the automatic retry, and 1 failure; after, 20 clean
> runs. ext/openssl/tests passes (264 passed, 0 failed).
cc @Girgias