[php-src] PR #25128: Fix opcache phar check
| From: | ndossche | Date: | Sun, 01 Nov 2026 14:07:48 +0000 |
| Subject: | [php-src] PR #25128: Fix opcache phar check | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-40186@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/25128
Author: ndossche
This is the cause of the flaky nightly failures on PPC for
issue0149.phpt. On slow
machines, enough time passes that request 2/3 are served from opcache rather than from the disk.
If we set opcache.file_update_protection=0, then the failure reproduces predictably.
The root cause is that the phar check in opcache only checks if the filename ends in
.phar whereas ext/phar checks whether .phar is anywhere in the filename.
This difference causes requests from the cache to not execute the stub, and therefore not execute
the Phar::mount() call in the test, and therefore fail the expectation.