Re: [php-gtk-cvs] cvs: php-gtk /test bug_gtkliststore_insert_with_array.php

No, please leave them in the test dir! They're useful for reference. Christian, they'd be even more useful if you'd mark the 'fix' with the pertinent file and revision number too, is that going to be straightforward for you? What we _do_ need to look at is porting the old test dir contents to PHP-GTK 2 and moving them to the demo dir - Christian, if you can make scribble.php (the version on my 'unofficial' webspace, or I can mail you a copy) run as part of your framework you're a better man than I am, it crashed for me when I tried. At present there's a fair amount of confusion over the test vs demo directories, basically because all our demos used to be in test... so having just files marked as 'bug_*' in there will make life easier for users too - they'll know to avoid it :) - Steph ----- Original Message ----- From: "Scott Mattocks" <scott@crisscott.com> To: "Christian Weiske" <cweiske@php.net> Cc: <php-gtk-cvs@lists.php.net> Sent: Thursday, October 20, 2005 1:44 PM Subject: Re: [php-gtk-cvs] cvs: php-gtk /test bug_gtkliststore_insert_with_array.php > I haven't had a chance to re-test this yet but I will tonight. > > If this bug is fixed, should this file be removed from CVS? I know it is > a good idea to leave it there in case we run into a similar problem > later but I can picture this directory getting pretty bogged down with > files that will likely never be useful again. > > Scott > > Christian Weiske wrote: > > cweiske Thu Oct 20 00:19:22 2005 EDT > > > > Modified files: > > /php-gtk/test bug_gtkliststore_insert_with_array.php > > Log: > > Bug has been fixed by Andrei > > > > > > http://cvs.php.net/diff.php/php-gtk/test/bug_gtkliststore_insert_with_array.php?r1=1.1&r2=1.2&ty=u > > Index: php-gtk/test/bug_gtkliststore_insert_with_array.php > > diff -u php-gtk/test/bug_gtkliststore_insert_with_array.php:1.1 php-gtk/test/bug_gtkliststore_insert_with_array.php:1.2 > > --- php-gtk/test/bug_gtkliststore_insert_with_array.php:1.1 Sat Oct 15 12:45:28 2005 > > +++ php-gtk/test/bug_gtkliststore_insert_with_array.php Thu Oct 20 00:19:18 2005 > > @@ -1,4 +1,8 @@ > > <?php > > +/** > > +* FIXED by Andrei on 2005-10-19 22:38 > > +* Problem reason: Wrong alloc used > > +*/ > > // Create a list store. > > $listStore = new GtkListStore(Gtk::TYPE_STRING, Gtk::TYPE_LONG, Gtk::TYPE_DOUBLE); > > > > @@ -70,7 +74,7 @@ > > $window = new GtkWindow(); > > $window->add($view); > > $window->show_all(); > > -$window->connect_object('destroy', array('gtk', > > 'main_quit')); > > +$window->connect_simple('destroy', array('gtk', > > 'main_quit')); > > gtk::main(); > > > > /* > > > > -- > Scott Mattocks > scott@crisscott.com > http://www.crisscott.com > http://pear.php.net/user/scottmattocks > > -- > PHP-GTK CVS Mailing List (http://gtk.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >