[PATCH] Re: some success :)

From: Date: Sun, 04 Sep 2005 05:45:49 +0000
Subject: [PATCH] Re: some success :)
References: 1 2 3 4 5 6 7 8 9 10 11 12 13 14  Groups: php.gtk.dev 
Request: Send a blank email to php-gtk-dev+get-1587@lists.php.net to get a copy of this message
He was trying to override properties, but it should've been methods - apart from that it was pretty close :) Patch attached, I daren't start committing C without you looking it over first but it works on my box [TM]. ----- Original Message ----- From: "Andrei Zmievski" <andrei@gravitonic.com> To: "Tom Rogers" <trogers@kwikin.com> Cc: "Steph" <steph@zend.com> Sent: Sunday, September 04, 2005 7:13 AM Subject: Re: [UNSURE] Re: some success :) > Uh, are you trying to override properties or methods? > > -Andrei > > > On Sep 3, 2005, at 9:00 PM, Tom Rogers wrote: > > > Hi, > > > > Here is my first attempt, it fixes > > > > GtkColorSelection get_current_color() > > GtkColorSelection get_previous_color() > > (Both reporting they need one value passed) > > > > %% > > override-prop GtkColorSelection get_current_color > > PHPG_PROP_READER > > { > > > > GdkColor php_retval; > > > > gtk_color_selection_get_current_color(GTK_COLOR_SELECTION > > (PHPG_GOBJECT(this_ptr)), &php_retval); > > phpg_gboxed_new(&return_value, GDK_TYPE_COLOR, &php_retval, > > TRUE, TRUE TSRMLS_CC); > > > > return SUCCESS; > > > > } > > > > %% > > override-prop GtkColorSelection get_previous_color > > PHPG_PROP_READER > > { > > > > GdkColor php_retval; > > > > gtk_color_selection_get_previous_color(GTK_COLOR_SELECTION > > (PHPG_GOBJECT(this_ptr)), &php_retval); > > phpg_gboxed_new(&return_value, GDK_TYPE_COLOR, &php_retval, > > TRUE, TRUE TSRMLS_CC); > > > > return SUCCESS; > > > > } > > > > > > ************************************************* > > What is the command line to rerun the generator scripts? > > Any rules/conventions regarding placement of new overides? > > > > -- > > regards, > > Tom > > >

Index: ext/gtk+/gtk.overrides =================================================================== RCS file: /repository/php-gtk/ext/gtk+/gtk.overrides,v retrieving revision 1.115 diff -u -r1.115 gtk.overrides --- ext/gtk+/gtk.overrides 3 Sep 2005 19:06:11 -0000 1.115 +++ ext/gtk+/gtk.overrides 4 Sep 2005 05:37:51 -0000 @@ -573,6 +573,46 @@ } %% }}} +%% {{{ GtkColorSelection +%% +override gtk_color_selection_get_current_color +PHP_METHOD +{ + + GdkColor color = { 0 , 0 , 0 , 0 }; + + if (ZEND_NUM_ARGS() > 0) { + php_error(E_WARNING, "%s::%s() requires 0 arguments, %d given", + get_active_class_name(NULL TSRMLS_CC), + get_active_function_name(TSRMLS_C), ZEND_NUM_ARGS()); + return; + } + + gtk_color_selection_get_current_color(GTK_COLOR_SELECTION(PHPG_GOBJECT(this_ptr)), &color); + phpg_gboxed_new(&return_value, GDK_TYPE_COLOR, &color, TRUE, TRUE TSRMLS_CC); + +} + +%% +override gtk_color_selection_get_previous_color +PHP_METHOD +{ + + GdkColor color = { 0 , 0 , 0 , 0 }; + + if (ZEND_NUM_ARGS() > 0) { + php_error(E_WARNING, "%s::%s() requires 0 arguments, %d given", + get_active_class_name(NULL TSRMLS_CC), + get_active_function_name(TSRMLS_C), ZEND_NUM_ARGS()); + return; + } + + gtk_color_selection_get_previous_color(GTK_COLOR_SELECTION(PHPG_GOBJECT(this_ptr)), &color); + phpg_gboxed_new(&return_value, GDK_TYPE_COLOR, &color, TRUE, TRUE TSRMLS_CC); + +} +%% }}} + %% include gtkcontainer.overrides %% {{{ GtkDialog
« previous php.gtk.dev (#1587) next »