Re: [PATCH] GtkComboBox/GtkTreeView::set_row_separator_func

Looks good, but a couple of notes. 1. Please keep your patches separate. The first patch also includes GtkAboutDialog stuff. 2. You are destroying retval before converting it to boolean. A better approach is something like:

    if (retval) {
        ret = zend_is_true(retval);
        zval_ptr_dtor(&retval);
    } else {
        ret = TRUE;
    }

3. You have an extraneous declaration line: +static gboolean phpg_tree_model_filter_visible_func_marshal(GtkTreeModel *model, GtkTreeIter *iter, gpointer data); 4. You need to add: +static gboolean phpg_tree_view_row_separator_func_marshal(GtkTreeModel *model, GtkTreeIter *iter, gpointer data); to the %headers section, otherwise you're not guaranteed that both places will have access to it. -Andrei On May 30, 2006, at 1:28 PM, Christian Weiske wrote:

Hi all, The patch for GtkComboBox/GtkTreeView::set_row_separator_func can be found at: http://xml.cweiske.de/patches/rowseparator_gtk.overrides.diff http://xml.cweiske.de/patches/rowseparator_gtktreeview.overrides.diff --Regards/MfG, Christian Weiske