Re: [PATCH] GtkAboutDialog email/url hooks

Some notes again: 1. You need to provide a way to unset the hook function. Probably just check that if the callback is IS_NULL, then unset it. You can use V! for that. 2. What did you mean by:

+    //I know the next line needs to be changed, but that didn't work:
+    //ZVAL_STRINGL(php_link, (char *)cp_link, cp_len, 1)
+    php_gtk_build_value(&php_link, "s", cp_link);

You need to allocate php_link before using ZVAL_STRINGL(). MAKE_STD_ZVAL(php_link); ZVAL_STRINGL(php_link, (char*)cp_link, cp_len, 1); 3. Whenever you have a callback/marshaller that is used by more than one method, put its declaration in %headers section. +static void phpg_about_dialog_activate_link_func_marshal(GtkAboutDialog *about, const gchar *link, gpointer data); -Andrei On May 21, 2006, at 6:50 AM, Christian Weiske wrote:

Hi at http://xml.cweiske.de/patches/aboutdialog-gtk.overrides.diff is a patch for the last two missing GtkAboutDialog methods, GtkAboutDialog::set_email_hook(callback); GtkAboutDialog::set_url_hook(callback); --Regards/MfG, Christian Weiske