#37500 [Opn]: Patches for GtkContainer::get/set_focus_chain, GtkWindow::g/s_default_icons

ID: 37500 Updated by: andrei@php.net Reported By: cweiske@php.net Status: Open Bug Type: PHP-GTK related Operating System: any PHP Version: 5.1.4 New Comment: A couple of notes: 1. You should prepend the widgets to the focus chain, instead of appending. Also, use better error messages: + if (php_gtk_check_class(*php_widget, gtkwidget_ce)) { + GtkWidget *widget = GTK_WIDGET(PHPG_GOBJECT(*php_widget)); + widgets = g_list_prepend(widgets, widget); + } else { + php_error(E_WARNING, "%s::%s() requires the focus chain elements to be objects of class GtkWidget", get_active_class_name(NULL TSRMLS_CC), get_active_function_name(TSRMLS_C)); + } 2. Why do you have this in gtk.defs: +(define-function gtk_tree_model_filter_new 3. See #1 for set_(default)_icon_list() also. Previous Comments: ------------------------------------------------------------------------ [2006-05-18 14:32:11] cweiske@php.net Description: ------------ Attached are patches for the following methods: GtkContainer::get_focus_chain GtkContainer::set_focus_chain GtkWindow::get_icon_list GtkWindow::set_icon_list GtkWindow::get_default_icon_list GtkWindow::set_default_icon_list GtkIconTheme::list_icons The patch files can be found at http://xml.cweiske.de/patches/gtk.defs.diff http://xml.cweiske.de/patches/gtkcontainer.overrides.diff http://xml.cweiske.de/patches/gtk.overrides.diff ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=37500&edit=1