Re: Fw: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_API.c zend_API.h zend_modules.h

OK, I'll knock something up. /me is checking out as she types

Why not. -Andrei On Jun 15, 2006, at 1:42 PM, Steph Fox wrote:

OK that's it, it's in. Now back to the question of whether to use it straight away? ----- Original Message ----- From: "Dmitry Stogov" <dmitry@php.net> To: <zend-engine-cvs@lists.php.net> Sent: Thursday, June 15, 2006 4:03 PM Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_API.c zend_API.h zend_modules.h

dmitry Thu Jun 15 14:03:21 2006 UTC

 Modified files:              (Branch: PHP_5_2)

/ZendEngine2 zend_API.c zend_API.h zend_modules.h Log: MFH: Added automatic module globals management. http://cvs.php.net/viewcvs.cgi/ZendEngine2/zend_API.c? r1=1.296.2.27.2.17&r2=1.296.2.27.2.18&diff_format=u Index: ZendEngine2/zend_API.c diff -u ZendEngine2/zend_API.c:1.296.2.27.2.17 ZendEngine2/ zend_API.c:1.296.2.27.2.18 --- ZendEngine2/zend_API.c:1.296.2.27.2.17 Wed Jun 7 09:43:54 2006 +++ ZendEngine2/zend_API.c Thu Jun 15 14:03:21 2006 @@ -18,7 +18,7 @@ +-------------------------------------------------------------------- --+ */ -/* $Id: zend_API.c,v 1.296.2.27.2.17 2006/06/07 09:43:54 helly Exp $ */ +/* $Id: zend_API.c,v 1.296.2.27.2.18 2006/06/15 14:03:21 dmitry Exp $ */ #include "zend.h" #include "zend_execute.h" @@ -1448,6 +1448,17 @@ } } + /* Initialize module globals */ + if (module->globals_size) { +#ifdef ZTS + ts_allocate_id(module->globals_id_ptr, module->globals_size, (ts_allocate_ctor) module->globals_ctor, (ts_allocate_dtor) module-

globals_dtor);

+#else + if (module->globals_ctor) { + module->globals_ctor(module->globals_ptr TSRMLS_CC); + } +#endif + } + if (module->module_startup_func) { EG(current_module) = module; if (module->module_startup_func(module->type, module-

module_number TSRMLS_CC)==FAILURE) {

@@ -1881,6 +1892,18 @@ #endif module->module_shutdown_func(module->type, module->module_number TSRMLS_CC); } + + /* Deinitilaise module globals */ + if (module->globals_size) { +#ifdef ZTS + ts_free_id(*module->globals_id_ptr); +#else + if (module->globals_dtor) { + module->globals_dtor(module->globals_ptr TSRMLS_CC); + } +#endif + } + module->module_started=0; if (module->functions) { zend_unregister_functions(module->functions, -1, NULL TSRMLS_CC); http://cvs.php.net/viewcvs.cgi/ZendEngine2/zend_API.h? r1=1.207.2.8.2.3&r2=1.207.2.8.2.4&diff_format=u Index: ZendEngine2/zend_API.h diff -u ZendEngine2/zend_API.h:1.207.2.8.2.3 ZendEngine2/ zend_API.h:1.207.2.8.2.4 --- ZendEngine2/zend_API.h:1.207.2.8.2.3 Wed Jun 7 09:43:54 2006 +++ ZendEngine2/zend_API.h Thu Jun 15 14:03:21 2006 @@ -18,7 +18,7 @@ +-------------------------------------------------------------------- --+ */ -/* $Id: zend_API.h,v 1.207.2.8.2.3 2006/06/07 09:43:54 helly Exp $ */ +/* $Id: zend_API.h,v 1.207.2.8.2.4 2006/06/15 14:03:21 dmitry Exp $ */ #ifndef ZEND_API_H #define ZEND_API_H @@ -79,6 +79,8 @@ #define ZEND_MODULE_DEACTIVATE_N(module) zm_deactivate_##module #define ZEND_MODULE_POST_ZEND_DEACTIVATE_N(module) zm_post_zend_deactivate_##module #define ZEND_MODULE_INFO_N(module) zm_info_##module +#define ZEND_MODULE_GLOBALS_CTOR_N(module) zm_globals_ctor_##module +#define ZEND_MODULE_GLOBALS_DTOR_N(module) zm_globals_dtor_##module /* Declaration macros */ #define ZEND_MODULE_STARTUP_D(module) int ZEND_MODULE_STARTUP_N (module)(INIT_FUNC_ARGS) @@ -87,6 +89,8 @@ #define ZEND_MODULE_DEACTIVATE_D(module) int ZEND_MODULE_DEACTIVATE_N(module)(SHUTDOWN_FUNC_ARGS) #define ZEND_MODULE_POST_ZEND_DEACTIVATE_D(module) int ZEND_MODULE_POST_ZEND_DEACTIVATE_N(module)(void) #define ZEND_MODULE_INFO_D(module) void ZEND_MODULE_INFO_N(module) (ZEND_MODULE_INFO_FUNC_ARGS) +#define ZEND_MODULE_GLOBALS_CTOR_D(module) void ZEND_MODULE_GLOBALS_CTOR_N(module)(zend_##module##_globals *module##_globals TSRMLS_DC) +#define ZEND_MODULE_GLOBALS_DTOR_D(module) void ZEND_MODULE_GLOBALS_DTOR_N(module)(zend_##module##_globals *module##_globals TSRMLS_DC) #define ZEND_GET_MODULE(name) \

    BEGIN_EXTERN_C()\

@@ -611,12 +615,16 @@ #define ZEND_RINIT ZEND_MODULE_ACTIVATE_N #define ZEND_RSHUTDOWN ZEND_MODULE_DEACTIVATE_N #define ZEND_MINFO ZEND_MODULE_INFO_N +#define ZEND_GINIT(module) ((void (*)(void* TSRMLS_DC)) (ZEND_MODULE_GLOBALS_CTOR_N(module))) +#define ZEND_GSHUTDOWN(module) ((void (*)(void* TSRMLS_DC)) (ZEND_MODULE_GLOBALS_DTOR_N(module))) #define ZEND_MINIT_FUNCTION ZEND_MODULE_STARTUP_D #define ZEND_MSHUTDOWN_FUNCTION ZEND_MODULE_SHUTDOWN_D #define ZEND_RINIT_FUNCTION ZEND_MODULE_ACTIVATE_D #define ZEND_RSHUTDOWN_FUNCTION ZEND_MODULE_DEACTIVATE_D #define ZEND_MINFO_FUNCTION ZEND_MODULE_INFO_D +#define ZEND_GINIT_FUNCTION ZEND_MODULE_GLOBALS_CTOR_D +#define ZEND_GSHUTDOWN_FUNCTION ZEND_MODULE_GLOBALS_DTOR_D END_EXTERN_C() http://cvs.php.net/viewcvs.cgi/ZendEngine2/zend_modules.h? r1=1.67.2.3.2.1&r2=1.67.2.3.2.2&diff_format=u Index: ZendEngine2/zend_modules.h diff -u ZendEngine2/zend_modules.h:1.67.2.3.2.1 ZendEngine2/ zend_modules.h:1.67.2.3.2.2 --- ZendEngine2/zend_modules.h:1.67.2.3.2.1 Tue May 9 23:53:23 2006 +++ ZendEngine2/zend_modules.h Thu Jun 15 14:03:21 2006 @@ -17,7 +17,7 @@ +-------------------------------------------------------------------- --+ */ -/* $Id: zend_modules.h,v 1.67.2.3.2.1 2006/05/09 23:53:23 helly Exp $ */ +/* $Id: zend_modules.h,v 1.67.2.3.2.2 2006/06/15 14:03:21 dmitry Exp $ */ #ifndef MODULES_H #define MODULES_H @@ -39,7 +39,7 @@ extern struct _zend_arg_info fifth_arg_force_ref[6]; extern struct _zend_arg_info all_args_by_ref[1]; -#define ZEND_MODULE_API_NO 20050922 +#define ZEND_MODULE_API_NO 20060613 #ifdef ZTS #define USING_ZTS 1 #else @@ -52,10 +52,18 @@ #define ZE2_STANDARD_MODULE_HEADER \ STANDARD_MODULE_HEADER_EX, ini_entries, NULL -#define STANDARD_MODULE_PROPERTIES_EX 0, 0, 0, NULL, 0 +#define STANDARD_MODULE_PROPERTIES_EX 0, 0, NULL, 0 + +#define NO_MODULE_GLOBASLS 0, NULL, NULL, NULL + +#ifdef ZTS +# define ZEND_MODULE_GLOBALS(module_name) sizeof (zend_##module_name##_globals), &module_name##_globals_id +#else +# define ZEND_MODULE_GLOBALS(module_name) sizeof (zend_##module_name##_globals), &module_name##_globals +#endif #define STANDARD_MODULE_PROPERTIES \ - NULL, STANDARD_MODULE_PROPERTIES_EX + NO_MODULE_GLOBASLS, NULL, STANDARD_MODULE_PROPERTIES_EX #define NO_VERSION_YET NULL @@ -81,8 +89,15 @@ int (*request_shutdown_func)(SHUTDOWN_FUNC_ARGS); void (*info_func)(ZEND_MODULE_INFO_FUNC_ARGS); char *version; + size_t globals_size; +#ifdef ZTS + ts_rsrc_id* globals_id_ptr; +#else + void* globals_ptr; +#endif + void (*globals_ctor)(void *global TSRMLS_DC); + void (*globals_dtor)(void *global TSRMLS_DC); int (*post_deactivate_func)(void); - int globals_id; int module_started; unsigned char type; void *handle; -- Zend Engine CVS Mailing List (http://cvs.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com

-- PHP-GTK Development Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

-- PHP-GTK Development Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com