Re: Re: [php-gtk-cvs] cvs: php-gtk /main php_gtk.h
| From: | Steph Fox | Date: | Sun, 18 Jun 2006 13:04:29 +0000 |
| Subject: | Re: Re: [php-gtk-cvs] cvs: php-gtk /main php_gtk.h | ||
| References: | 1 2 | Groups: | php.gtk.dev |
| Request: | Send a blank email to php-gtk-dev+get-3066@lists.php.net to get a copy of this message | ||
Because there's absolutely no need to do what you suggested (i.e. declare them in a different way) alonga PHP 5... so having done the leg work to discover that, it made sense to just put something in to allow everything to run as advertised.
Um, why didn't you wait for me to make a fix? I thought I said I'd take care of it.. -Andrei On Jun 17, 2006, at 12:59 PM, Steph Fox wrote:I should probably make this very clear. php_lookup isn't defined in PHP 5 anywhere grep can see it. ----- Original Message ----- From: "Steph Fox" <sfox@php.net> To: <php-gtk-cvs@lists.php.net> Sent: Saturday, June 17, 2006 6:59 PM Subject: [php-gtk-cvs] cvs: php-gtk /main php_gtk.h-- PHP-GTK Development Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.comsfox Sat Jun 17 16:59:06 2006 UTC Modified files: /php-gtk/main php_gtk.h Log: - Workaround for the 'lookup' issue. - The only place 'lookup' was used by the end of the PHP 4.3 series was in ext/expat. - It isn't used anywhere in PHP 5 or its core extensions. http://cvs.php.net/viewcvs.cgi/php-gtk/main/php_gtk.h? r1=1.130&r2=1.131&diff_format=u Index: php-gtk/main/php_gtk.h diff -u php-gtk/main/php_gtk.h:1.130 php-gtk/main/php_gtk.h:1.131 --- php-gtk/main/php_gtk.h:1.130 Sat Jun 3 18:07:41 2006 +++ php-gtk/main/php_gtk.h Sat Jun 17 16:59:05 2006 @@ -18,7 +18,7 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ -/* $Id: php_gtk.h,v 1.130 2006/06/03 18:07:41 andrei Exp $: */ +/* $Id: php_gtk.h,v 1.131 2006/06/17 16:59:05 sfox Exp $: */ #ifndef _PHP_GTK_H #define _PHP_GTK_H @@ -31,6 +31,11 @@ #include "config.h" #endif +/* workaround for expat-related declaration in PHP compat file */ +#ifdef lookup +#undef lookup +#endif + #if HAVE_PHP_GTK #include "zend_objects_API.h" -- PHP-GTK CVS Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php __________ NOD32 1.1380 (20060125) Information __________ This message was checked by NOD32 antivirus system. http://www.eset.com