So what's the problem?
if (!php_gtk_parse_args(ZEND_NUM_ARGS(), "|ub", &text, &free_text, &use_underline)) {
PHPG_THROW_CONSTRUCT_EXCEPTION(GtkButton);
}
I'd expect to see
if (!php_gtk_parse_args(ZEND_NUM_ARGS(), "|ub", &text, &free_text, &use_underline)) {
return;
}
Wouldn't you?
-Andrei
On Jun 18, 2006, at 12:29 PM, Steph Fox wrote:
Erm, let me clarify that... It doesn't throw an exception, no - it throws an error, same as the rest of PHP on parameter parsing.
1) It doesn't look right to me to be throwing construct exceptions when
someone gets the argument list wrong. There's already an error mechanism
in place for that, and it's not really 'exceptional'. We should be using
them only when the actual object creation fails IMHO.
php_gtk_parse_args() doesn't throw an exception IMO, so we shouldn't do
either but do the same as this func.
I think you'll find it does.
2) We still have the gtk and gdk overrides from PHP-GTK 1 in the source.
Are these still useful to anyone or can we lose them now?
Andrei put them in to have a reference to make php-gtk2 overrides. Since
we have a CVS branch to look and the pygtk sources, we don't need them
anymore.
I think so too, but I was really asking Andrei - since that was true anyway at the start.
3) Same goes for bits and pieces of out-commented PHP-GTK 1 code in
/main - useful, or 'can go'?
Remove it. If we need it, we can look at the php-gtk1 branch IMO.
As above.
4) We need to come to some agreement over what should happen to the demo
and test dirs.
I will move the subscripts to a subdirectory, so that phpgtk2demo.php is
the only one in the demos directory.
That'd be cool, thanks!
Andrei, do you want to keep your own stockbrowser demo or it is ok to
keep only the version that is integratable into phpgtk2demo.php?
-- Regards/MfG,
Christian Weiske
-- PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
-- PHP-GTK Development Mailing List (http://gtk.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
__________ NOD32 1.1380 (20060125) Information __________
This message was checked by NOD32 antivirus system.
http://www.eset.com