Re: more cleaning up...

From: Date: Sun, 18 Jun 2006 21:36:59 +0000
Subject: Re: more cleaning up...
References: 1 2  Groups: php.gtk.dev 
Request: Send a blank email to php-gtk-dev+get-3083@lists.php.net to get a copy of this message
Hiya,
Coupla questions here. 1) It doesn't look right to me to be throwing construct exceptions when someone gets the argument list wrong. There's already an error mechanism in place for that, and it's not really 'exceptional'. We should be using them only when the actual object creation fails IMHO.
Where do we throw exceptions on wrong arguments?
All over the source? I think some of those lines are even generated.
2) We still have the gtk and gdk overrides from PHP-GTK 1 in the source. Are these still useful to anyone or can we lose them now?
Where? Please be specific.
in ext/gtk+. They're fairly big files, at least the gtk one is.
3) Same goes for bits and pieces of out-commented PHP-GTK 1 code in /main - useful, or 'can go'?
Keep them for now.
kk
4) We need to come to some agreement over what should happen to the demo and test dirs.
Keep demo, get rid of stuff in test/ that's not unittests.
You sure? It was useful to have that yesterday, and unittests aren't actually written yet as such. - Steph

« previous php.gtk.dev (#3083) next »