Re: Overrides
| From: | Andrei Zmievski | Date: | Sat, 27 Jan 2007 18:50:17 +0000 |
| Subject: | Re: Overrides | ||
| References: | 1 | Groups: | php.gtk.dev |
| Request: | Send a blank email to php-gtk-dev+get-3598@lists.php.net to get a copy of this message | ||
Elizabeth,
The patch looks good, except for the following. When you get an enum from a call to a Gtk+ function, you can simply return it as a long. The phpg_gvalue_get_enum() is meant to convert incoming zval to an integer enum value, not the other way around. So you can just do:
add_next_index_long(return_value, pos);
I've given you commit access to the tree so you can commit the patch yourself once you fix it. But please continue sending patches to the list first, at least for a little while.
-Andrei
On Jan 24, 2007, at 6:46 AM, Elizabeth Smith wrote:
+ phpg_gvalue_get_enum(GTK_TYPE_TREE_VIEW_DROP_POSITION, php_pos, (gint *)&pos); + add_next_index_zval(return_value, php_pos);+}