Compiler warnings and etc
| From: | Steph Fox | Date: | Wed, 23 Jan 2008 02:33:58 +0000 |
| Subject: | Compiler warnings and etc | ||
| Groups: | php.gtk.dev | ||
| Request: | Send a blank email to php-gtk-dev+get-4083@lists.php.net to get a copy of this message | ||
Andrei, Elizabeth, all -
In the gtk_curve_set_vector() override, the line:
vectors[i] = Z_LVAL_PP(data);
throws a compiler warning under MSVC 6. I changed it to:
vectors[i] = Z_DVAL_PP(data);
since the data points to a double, not a long. Fixing this doesn't actually clear the warning, thanks to a bug in the VC6 compiler, so I just wanted to highlight that change in case it causes any trouble.
The other thing relates to the 'hack' to load GD under Windows. There were a couple of compiler warnings I killed in there, but I've no idea how to test the functionality. Can you please either mail me a test script or test it for yourself fresh out of CVS? Note: I moved DL_FETCH_SYMBOL to GetProcAddress for clarity in the win32-only section, they're one and the same thing to Zend except that GetProcAddress is rather better documented ;)
Just two compiler warnings left - one (GtkEntry::get_inner_border() in GTK 2.10 and up) will probably need an override if we really want to return a GtkBorder struct as a constant (??? defs-munging might be nicer), the other is the DVAL one mentioned earlier.
Assuming I didn't actually break anything, that's me done for pre-release stuff. I'd still like to do things with the Windows build system, but that won't affect anything else.
Some testing would be good at this stage...
- Steph