Bug #50888 [Asn->Csd]: Patch Request: Detection of Microsoft VS.NET 2008

Edit report at http://bugs.php.net/bug.php?id=50888&edit=1 ID: 50888 Updated by: kalle@php.net Reported by: thomas dot worm at thomas-worm dot de Summary: Patch Request: Detection of Microsoft VS.NET 2008 -Status: Assigned +Status: Closed Type: Bug Package: PHP-GTK related Operating System: Windows PHP Version: 5.3.1 Assigned To: kalle New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2010-03-17 17:00:14] kalle@php.net Automatic comment from SVN on behalf of kalle Revision: http://svn.php.net/viewvc/?view=revision&revision=296329 Log: Improve Windows build system take #1 * Generate configure.bat * Use php_gtk_build as first priority build folder to prevent interfering with php-src builds * Write 2 blank lines before the error message in ERROR() to prevent error messages while detecting locations to look screwy * Proper detect MSVC versions, merged from php-src (Fixes #50888) ------------------------------------------------------------------------ [2010-03-16 18:39:21] kalle@php.net Assigned to myself, I got a patch which detects the other missing MSVC versions along with a few other improvements to the Windows build of GTK. ------------------------------------------------------------------------ [2010-01-30 21:15:51] thomas dot worm at thomas-worm dot de Description: ------------ When you compile PHP-GTK with Microsoft VS.NET 2008 the compiler will not be detected properly. This could be fixed with following patch: diff -ruN php-gtk.orig/win32/config.w32.in php-gtk/win32/config.w32.in --- php-gtk.orig/win32/config.w32.in 2010-01-16 19:02:31.074820100 +0100 +++ php-gtk/win32/config.w32.in 2010-01-16 19:05:17.334329600 +0100 @@ -40,6 +40,9 @@ if (VCVERS == 14) { msversion = "Microsoft VS.NET 2005"; } + if (VCVERS == 15) { + msversion = "Microsoft VS.NET 2008"; + } STDOUT.WriteLine("Detected compiler version: " + msversion); } else { Reproduce code: --------------- cscript /nologo configure.js Expected result: ---------------- Detected compiler version: Microsoft VS.NET 2008 Actual result: -------------- Detected compiler version: unknown ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=50888&edit=1