Re: Diff for conflicting method name (Gtk-2.20)
| From: | Paul Horton | Date: | Sun, 04 Sep 2011 22:29:07 +0000 |
| Subject: | Re: Diff for conflicting method name (Gtk-2.20) | ||
| References: | 1 2 3 4 | Groups: | php.gtk.dev |
| Request: | Send a blank email to php-gtk-dev+get-4530@lists.php.net to get a copy of this message | ||
Mark,
This is to fix a naming conflict thus avoiding overriding, which doesn't
occur in GTK.
P
On 3 September 2011 17:44, Mark Skilbeck <m@iammark.us> wrote:
> What is the reasoning for this patch? AFAIK there are no errors/bugs
> related to this. Also, as the c-name shows, the correct naming for this
> function would be the currently used name (GtkToolPalette::set_style).
>
> Mark.
>
> P.S. My apologies for not replying to the mailing list previously.
>
> On Sat, Sep 03, 2011 at 05:38:15PM +0100, Paul Horton wrote:
> > Oops - first time for this.
> >
> > Here goes again.
> >
> > Paul
> >
> > On 3 September 2011 17:35, Mark Skilbeck <m@iammark.us> wrote:
> >
> > > I see no attachments.
> > >
> > > Be sure to use .txt as the extension for the attachment - AFAIR the
> > > mailing lists shit themselves when a different extension is used.
> > >
> > > Mark.
> > >
> > > On Sat, Sep 03, 2011 at 05:19:49PM +0100, Paul Horton wrote:
> > > > Diff attached which fixed method naming conflict.
> > > >
> > > > Paul
> > >
> > > > --
> > > > PHP-GTK Development Mailing List (http://gtk.php.net/)
> > > > To unsubscribe, visit:
> > > > http://www.php.net/unsub.php
> > >
> > >
>
> > Index: ext/gtk+/gtk-2.20.defs
> > ===================================================================
> > --- ext/gtk+/gtk-2.20.defs (revision 316074)
> > +++ ext/gtk+/gtk-2.20.defs (working copy)
> > @@ -88,7 +88,7 @@
> > (return-type "none")
> > )
> >
> > -(define-method set_style
> > +(define-method set_toolbar_style
> > (of-object "GtkToolPalette")
> > (c-name "gtk_tool_palette_set_style")
> > (return-type "none")
>
>