cvs: php-gtk / TODO /generator generator.php
| From: | Andrei Zmievski | Date: | Thu, 08 Mar 2001 22:08:36 +0000 |
| Subject: | cvs: php-gtk / TODO /generator generator.php | ||
| Groups: | php.gtk | ||
| Request: | Send a blank email to php-gtk+get-582@lists.php.net to get a copy of this message | ||
andrei Thu Mar 8 14:08:36 2001 EDT
Modified files:
/php-gtk TODO
/php-gtk/generator generator.php
Log:
Disable construction of abstract or unimplemented classes.
Index: php-gtk/TODO
diff -u php-gtk/TODO:1.21 php-gtk/TODO:1.22
--- php-gtk/TODO:1.21 Wed Mar 7 18:35:49 2001
+++ php-gtk/TODO Thu Mar 8 14:08:36 2001
@@ -5,6 +5,7 @@
* Provide access to GTK version number.
* Fix $dialog->vbox->show() crash.
* See what other object definitions might have been missed by h2def.py.
+* Add missing field defs to gtk.defs.
In PHP
------
Index: php-gtk/generator/generator.php
diff -u php-gtk/generator/generator.php:1.14 php-gtk/generator/generator.php:1.15
--- php-gtk/generator/generator.php:1.14 Wed Mar 7 07:03:35 2001
+++ php-gtk/generator/generator.php Thu Mar 8 14:08:36 2001
@@ -19,7 +19,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
-/* $Id: generator.php,v 1.14 2001/03/07 15:03:35 andrei Exp $ */
+/* $Id: generator.php,v 1.15 2001/03/08 22:08:36 andrei Exp $ */
/*
* Significant portions of this generator are based on the pygtk code generator
@@ -372,15 +372,18 @@
$function_entry = sprintf($this->function_entry, $this->prefix . "_" .
$object_lname);
$constructor = $this->parser->find_constructor($object);
- if ($this->overrides->is_overriden($constructor->c_name)) {
+ if (!$constructor || $this->overrides->is_ignored($constructor->c_name)) {
+ $function_entry .= sprintf($function_entry_tpl,
+ strtolower($object->c_name),
+ 'no_constructor', 'NULL');
+ } else if ($this->overrides->is_overriden($constructor->c_name)) {
list(, $constructor_override) = $this->overrides->get_override($constructor->c_name);
fwrite($fp, $constructor_override . "\n");
$function_entry .= sprintf($function_entry_tpl,
strtolower($constructor->is_constructor_of),
strtolower($constructor->c_name),
'NULL');
- }
- else if ($constructor != null &&
!$this->overrides->is_ignored($constructor->c_name)) {
+ } else if (!$this->overrides->is_ignored($constructor->c_name)) {
if ($byref = $this->write_constructor($fp, $object->c_name, $constructor)) {
$function_entry .= sprintf($function_entry_tpl,
strtolower($constructor->is_constructor_of),