Re: Re: Question on zend_make_printable
| From: | Marcus Boerger | Date: | Sat, 03 Jun 2006 12:02:30 +0000 |
| Subject: | Re: Re: Question on zend_make_printable | ||
| References: | 1 2 3 | Groups: | php.i18n |
| Request: | Send a blank email to php-i18n+get-1009@lists.php.net to get a copy of this message | ||
Hello guys,
the first option is of cause kind of easy:
ZEND_API void zend_make_text_zval(zval *expr, zval *expr_copy, int *use_copy)
{
if (UG(unicode)) {
zend_make_unicode_zval(expr, expr_copy, use_copy);
} else {
zend_make_string_zval(expr, expr_copy, use_copy);
}
}
best regards
marcus
Saturday, June 3, 2006, 1:58:36 PM, you wrote:
> Hello Michael,
> in that case i see two options. First provide a third version that
> choses between unicode/string automatically which is the reight way
> of a lot of stuff internally and stay with the old stuuf. And second
> apply the output encoding at the end of the function. Thinking about
> it the first solution makes much more sense.
> best regards
> marcus
> Saturday, June 3, 2006, 1:50:26 PM, you wrote:
>> Marcus Boerger wrote:
>>> Hello Anrei,
>>>
>>> why don't we simply make zend_make_printable_zval() call on of
>>> zend_make_unicode_zval/zend_make_string_zval() depending on ini
>>> setting unicode_semantics, see attached patch.
>> Probably, because make_printable_zval uses output_encoding?