Re: php 4.3.2 FYI

ldg@ulysium.net wrote: > Here's a bit of info for the developers that may be helpful a little: > After applying a couple of fixes in configure, I accidentally found an other > occurrence of something that causes errors. Although it didn't cause the > error for me, because it's in some fastcgi stuff which I don't turn on. > > echo "configure:8683: checking whether to enable fastcgi support" >&5 > PHP_LIBFCGI_DIR="$abs_srcdir/sapi/cgi/libfcgi" > if test -z $PHP_LIBFCGI_DIR; then > echo "$PHP_LIBFCGI_DIR does not exist" > exit 1 > fi > > I guess the test line also needs the variable quoted as in those other two > places (for jpeg and tiff). > Maybe this could be fixed in the next release. No, in this instance it does not need to be quoted. A variable only needs quoting if it's possible that it is completely empty. And the line PHP_LIBFCGI_DIR="$abs_srcdir/sapi/cgi/libfcgi" guarantees that $PHP_LIBFCGI_DIR can never be empty (even if $abs_srcdir is empty, there's still "/sapi/cgi/libfcgi" left). Regards... Michael