Re: [INTERNALS-WIN] Re: new crypt implementation, latest DES version used, blowfish support

Hi Pierre,

Alexander Peslyak (Solar designer), the author of the Blowfish implementation and known security expert, was kind enough to review my code and point me to a better implementation of the DES (his revision of the FreeSec code). It does not use any locking mechanism (being fully reentrant), provides extended DES support (not only standard) and is under BSD license (always preferable than the lgpl one we used until now).

Excuse me displaying my ignorance (this really isn't my area) - Alexander's code is already in the PHP core. Is there some reason for a Windows-specific crypt implementation? It looks to me like MD5 and standard DES are covered twice over in your current patch and the BLOWFISH check could be shared x-platform, but I could be missing something? Thanks, - Steph