Re: [INTERNALS-WIN] #45456 (_WIN32_WINNT) and fix VC9, zend/

Aloha! On Mon, Jul 14, 2008 at 8:56 PM, Stanislav Malyshev <stas@zend.com> wrote: > Hi! > >> As far as I remember, it already uses main/config.w32.h before. Now it >> is generalized to avoid this exact problem (and maybe other). > > Only in zend_config.w32.h when generated by PHP AFAIK. I don't see any other > references in any of Zend sources. Is (or can be) zend_config.w32.h included when needed then? Then only this file will include main/config.w32.h. >> As I can understand the problem if it was an extension but not in this >> case. I don't think that duplicating the config file is a good idea as >> it may only introduce possible conflicts or bad side effects >> (different definition for the same thing at different locations). > > When the engine is configured by PHP, zend config just load PHP config. > However, it can be configured independently, in which case it builds its > own config. As I see the change is just some windows constant, I am sure it > would be easy to make zend config work the right way. It could be easy yes. The idea of having this constant in config.w32.h (and in zend_config if it uses it) is to be able to define the target at configure time. We are working on specialized/optimized versions which rely on OS specific features. It would make our work easier to have only one place to change :) About having a specific zend_config.w32.h to replace config.w32.h: I'm not sure it is worth the effort (for windows). We can always do it later if we feel like it is necessary. But from a technical point of view, I see no issue to use config.w32.h for now, or did I miss something? :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org