Re: [INTERNALS-WIN] end of support for VC6 in trunk
| From: | Pierre Joye | Date: | Sun, 11 Oct 2009 21:05:11 +0000 |
| Subject: | Re: [INTERNALS-WIN] end of support for VC6 in trunk | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.internals.win |
| Request: | Send a blank email to internals-win+get-634@lists.php.net to get a copy of this message | ||
hi,
Applied.
On Sun, Oct 4, 2009 at 6:16 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> hi William,
>
> On Tue, Sep 22, 2009 at 11:07 PM, William A. Rowe, Jr.
> <wrowe@rowe-clan.net> wrote:
>> William A. Rowe, Jr. wrote:
>>> Pierre Joye wrote:
>>>>> Since the whole mod_php SetIni is not threadsafe,
>>>> What are you refering to here? :)
>>>
>>> Just looking at sapi/apache_hooks, it
>>> seems that ini processing changed significantly between 5.2 and 5.3.
>>
>> I'm evaluating this, it may take a couple days to get my head around
>> the code since I had a couple other urgent items on my plate right now.
>> If I see any issues, I'll sound off this coming week.
>
> I may have found something that could cause issues in TS SAPI, inside
> the php.ini management code.
>
> We were initializing a static point to the GetSystemWindowsDirectory
> function, without worrying about concurrent access (init time). As
> this function is available now in our minimal windows versions, I
> simply use GetSystemWindowsDirectory directly instead of using
> LoadLibrary and GetProcAddress.
>
> Patch attached.
>
> Cheers,
> --
> Pierre
>
> http://blog.thepimp.net |
> http://www.libgd.org
>
--
Pierre
http://blog.thepimp.net | http://www.libgd.org