Re: [INTERNALS-WIN] Sorry for the intrusion, but...

On Wed, Jul 16, 2008 at 11:59 PM, Steph Fox <steph@php.net> wrote: > > if (!ADD_EXTENSION_DEP('simplexml', 'spl', true)) { > MESSAGE("\tSPL support in simplexml disabled"); > } > > This is one example of how ADD_EXTENSION_DEP() was never intended to be > used, and there are several of them in PHP_5_3 branch at present. > > ADD_EXTENSION_DEP() will return error messages all by itself when the > occasion demands it, for a start. > > Can I fix inappropriate usage, or will fixing mean treading on peoples' > toes? No, as I told you already, there is nothing to fix here. So please don't change anything in this area. When a dep check is done, it is necessary to know if it succeeded or not, not visually (message printed out) but in the script. It is easy to check with the DOM extension, simply try a snap build with no library but bindlib in the dep path. > ps Update on the generated .dsp stuff if anyone's interested: everything now > *builds* on my box excepting SAPI dlls, which I haven't looked at yet. Also, > the welcome discovery that it's possible to convert VC6 project files all > the way up to VC9 (and beyond?) from the cmdline means this exercise might > not be a complete waste of time after all ;) We never agreed on that, but if you like to do it, please do but only without touching anything else please. Please remove the option for configure script and leave it self contained. It is already painful enough to deal with the two branches while some only commits to one. -- Pierre http://blog.thepimp.net | http://www.libgd.org