Re: [INTERNALS-WIN] Advice for enhancing ext/standard/proc_open.c (Windows CLI only)
| From: | NoteWorthy Online | Date: | Thu, 26 Aug 2010 22:42:41 +0000 |
| Subject: | Re: [INTERNALS-WIN] Advice for enhancing ext/standard/proc_open.c (Windows CLI only) | ||
| References: | 1 2 | Groups: | php.internals.win |
| Request: | Send a blank email to internals-win+get-718@lists.php.net to get a copy of this message | ||
Hi:
Thanks for taking the time to respond earlier. I figured that I would give it one more try...
However the patch looks wrong. It kills the bypass shell option, which is not something we like to do.In response to your apparent concern, I have changed the patch in two ways: 1) Added a "!GetConsoleWindow()" check. Now, this patch only applies when the CLI version of PHP is executing without a console window (much like other sapi types). 2) Switched to using the CREATE_NO_WINDOW flag, which is already used for other sapi types, regardless of the setting for bypass_shell. The updated patch is shown in full here: http://github.com/downloads/nwsw/nwc2utsk/proc_open.diff Hopefully, this makes the patch better... Thanks for your time, Eric, http://noteworthysoftware.com