Can I have karma for pecl/win32service please?
| From: | Richard Quadling | Date: | Wed, 29 Sep 2010 13:11:12 +0000 |
| Subject: | Can I have karma for pecl/win32service please? | ||
| Groups: | php.internals.win | ||
| Request: | Send a blank email to internals-win+get-720@lists.php.net to get a copy of this message | ||
Hi.
I've been using this extension for a while and I've added a few things
which I would like to commit.
1 - White space and a missing /* }}} */.
2 - Added the reflection data (arginfo / PHP_FE(win32_xxxx,
arginfo_win32_xxxx) ).
3 - Add support allowing the service description to be set.
4 - Allow a service the option of interacting with the desktop (add
SERVICE_INTERACTIVE_PROCESS to dwServiceType).
5 - Allow a service to accept pause requests (add SERVICE_ACCEPT_PAUSE
to dwControlsAccepted).
6 - Add support for check_point to SetServiceStatus (useful when
starting/stopping and there are several steps to do before the service
is ready).
7 - Additional constants to allow userland code to support pausing and
error handling.
8 - Some reworking around freeing the service path and parameters.
9 - Some reworking around the error handling at the tail end of
win32_create_service.
10 - Some reworking around the error handling at the tail end of
win32_delete_service.
The patches would be committed separately.
I'd also be handling the documentation.
I've no idea about getting this extension to a release state. There
are no tests. Not really sure how to go about writing these tests as
they would only run on a Windows system.
Regards,
Richard Quadling.
--
Richard Quadling
Twitter : EE : Zend
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY