Re: json_encode() / json_decode() warnings

Jakub Zelenka wrote:

On Sat, Jul 29, 2017 at 7:10 PM, Niklas Keller <me@kelunik.com> wrote:

Andrea Faulds <ajf@ajf.me> schrieb am Sa., 29. Juli 2017, 18:55:

Hi Craig, Craig Duncan wrote:

On 29 July 2017 at 15:16, Andrea Faulds <ajf@ajf.me> wrote:

Could we not simply make it a flag? e.g.

    $bar = json_encode($foo, JSON_THROW_EXCEPTIONS);
    $baz = json_decode($bar, false, 512, JSON_THROW_EXCEPTIONS);

That wouldn't break backwards-compatibility, but would still provide

the

desired functionality. :)

Hi Andrea, although that wouldn't break compatibility, it doesn't

protect

new developers from using them dangerously. That desired functionality is available in many userland libraries, I

don't

think we gain much from adding it to core. My aim is to make the core functions easier/safer to use out of the

box.

That's true, but if we add it to core we can save people reimplementing it themselves or adding an extra dependency, and perhaps more pertinently, it could be the first step to making this the default behaviour.

Thanks for that very good idea. @Sara: Can we please get that into 7.2?

I agree that it might be a useful feature for some users but I don't see any need to break a release rules for that (I mean adding new features in beta stage). Also the PR needs to have a full agreement which is not the case atm. (still some open questions) so I wouldn't definitely rush with adding that to 7.2. This should go just to master if all parts are agreed IMHO. That's of course up to RM and this is just my opinion. :)

There's no significant open questions, it's all bikeshedding over tiny details. -- Andrea Faulds https://ajf.me/