Re: [RFC] Deprecate the extract function in PHP 7.3

Hi! > As a second parameter the extract function takes some options > to > make this function less dangerous, like EXTR_SKIP that I'd start with specifying what exactly is "dangerous" in this function. So far I don't see any specific danger. You can shoot yourself in the foot, so you can with many other tools in the language. > I seriously doubt the usefulness of this function, especially looking > at the potential risks. The fact that overwriting the local variables Which risks? This function is used by real-life code, and unless you do something like extract($_GET) in global scope I don't see any problem. With extract($_GET) we could then also propose to remove all file functions because fopen($_GET['filename']) or unlink($_GET['filename']) are also dangerous. But if you use it properly, I don't see what "risks" are there. > Any thoughts? -1 so far, I don't see what problem you are trying to solve. -- Stas Malyshev smalyshev@gmail.com